New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add splashscreens member + purpose (closes #510) #530
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1272,6 +1272,11 @@ <h3> | |
<var>manifest</var>, <var>manifest URL</var>, and "icons" as | ||
arguments. | ||
</li> | ||
<li>Let <var>splashscreens</var> of <var>parsed manifest</var> be the | ||
result of running the <a>steps for processing an array of images</a> | ||
with <var>manifest</var>, <var>manifest URL</var>, and | ||
"splashscreens" as arguments. | ||
</li> | ||
<li>Let <var>scope</var> of <var>parsed manifest</var> be the result | ||
of running the <a>steps for processing the <code>scope</code> | ||
member</a> with <var>manifest</var>, <var>manifest URL</var>, | ||
|
@@ -1747,16 +1752,6 @@ <h3> | |
The <code>icons</code> member is processed using the <a>steps for | ||
processing an array of images</a>. | ||
</p> | ||
<p> | ||
If there are multiple equally appropriate icons in <var>icons</var>, | ||
a user agent MUST use the last one declared in order at the time that | ||
the user agent collected the list of <var>icons</var>. If the user | ||
agent tries to use an icon but that icon is determined, upon closer | ||
examination, to in fact be inappropriate (e.g. because its content | ||
type is unsupported), then the user agent MUST try the | ||
next-most-appropriate icon as determined by examining the <a>image | ||
object's</a> members. | ||
</p> | ||
<div class="example"> | ||
<p> | ||
In the following example, the developer has made the following | ||
|
@@ -1930,6 +1925,43 @@ <h3> | |
</li> | ||
</ol> | ||
</section> | ||
<section> | ||
<h3> | ||
<code>splashscreens</code> member | ||
</h3> | ||
<p> | ||
A <dfn>splash screen</dfn> is a graphical representation (usually an | ||
image on a background color) that is presented as the end user before | ||
the user agent is able render content. A splash screen is intended to | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a few typos caught:
|
||
convey to the end-user that the web application is being prepared for | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
them in the background. | ||
</p> | ||
<p> | ||
When showing a <a>splash screen</a>, a user agent MUST expose the | ||
loading state of the application via the platform's accessibility | ||
API(s). | ||
</p> | ||
<p> | ||
The <dfn id="member-splashscreens"><code>splashscreens</code> | ||
member</dfn> is an <a>array</a> of <a>image objects</a> that can | ||
serve as the splash screen for a web application. | ||
</p> | ||
<pre class="example"> | ||
{ | ||
"splashscreens": [{ | ||
"src": "icon/lowres.webp", | ||
"sizes": "148x148", | ||
"type": "image/webp" | ||
}, { | ||
"src": "icon/lowres", | ||
"sizes": "248x248" | ||
}, { | ||
"src": "icon/hd_hi.svg", | ||
"sizes": "1000x1000" | ||
}] | ||
} | ||
</pre> | ||
</section> | ||
<section> | ||
<h3> | ||
<code>start_url</code> member | ||
|
@@ -2315,6 +2347,16 @@ <h2> | |
scenarios to avoid losing important information through, e.g., change | ||
of color or clipped corners. | ||
</p> | ||
<p> | ||
Where there are multiple equally appropriate <a>image objects</a> for a | ||
particular <a>purpose</a> or manifest member, a user agent MUST use the | ||
last one declared in order at the time that the user agent collected | ||
the list of image objects. If the user agent tries to use an image | ||
object but that image is determined, upon closer examination, to in | ||
fact be inappropriate (e.g. because its content type is unsupported), | ||
then the user agent MUST try the next-most-appropriate image as | ||
determined by examining the <a>image object's</a> members. | ||
</p> | ||
<section> | ||
<h3> | ||
Fetching image objects | ||
|
@@ -2439,6 +2481,13 @@ <h3> | |
A user agent can present this icon where space constraints and/or | ||
color requirements differ from those of the application icon. | ||
</dd> | ||
<dt> | ||
<dfn data-lt="splashscreen purpose">splashscreen</dfn>: | ||
</dt> | ||
<dd> | ||
A user agent can present this icon where it would present a | ||
<a>splash screen</a>. | ||
</dd> | ||
<dt> | ||
<dfn data-lt="any purpose">any</dfn>: | ||
</dt> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this read
splashscreens
instead ofsplash screen
?the other member sections start like this. is that an issue