[Index | Example manifests] Adds simple example #557
Conversation
Adds a simple manifest example with name, description, and icons (just one) This is intended to address the simple example part of Issue #533 Signed-off-by: Rob Dolin <robdolin@microsoft.com>
index.html
Outdated
| "description": "This app helps you donate to worthy causes.", | ||
| "icons": [{ | ||
| "src": "icon/lowres.png", | ||
| "sizes": "64x64" |
There was a problem hiding this comment.
Probably should use a bigger icon, like 144x144
index.html
Outdated
| The following shows a typical <a>manifest</a>. | ||
| The following shows a very simple <a>manifest</a>. | ||
| </p> | ||
| <pre class="example json" title="typical manifest"> |
There was a problem hiding this comment.
Do you mean I should update the title of the pull request, the "Example Manifests" title, or a different title?
There was a problem hiding this comment.
s/typical/very simple/ on L134.
|
LGTM with comments, thanks! |
Makes the size of the icon in the very simple example larger
Original PR missed updating the `title` attribute on the `pre` element Signed-off-by: Rob Dolin <robdolin@microsoft.com>
|
LGTM. |
index.html
Outdated
| "sizes": "192x192" | ||
| }] | ||
| } | ||
| </pre> <p> |
There was a problem hiding this comment.
nit: please run over HTML5 tidy on the doc :)
Also, you can align the example code with the pre tag if you wish. I think the highlighter takes care of alignment for you.
There was a problem hiding this comment.
Thanks @marcoscaceres. I've submitted a quick commit fixing this via GitHub's web-based editor.
If that looks good, please merge.
If not, please push-back and I can do the full HTML5 tidy process when I get to my desk at work.
Fixes line 143 where `</pre>` was not indented and `<p>` was missing a new line >Also, you can align the example code with the pre tag if you wish. I think the highlighter takes care of alignment for you. Fixed with this commit Signed-off-by: Rob Dolin <robdolin@microsoft.com>
Adds a simple manifest example with name, description, and icons (just one)
This is intended to address the simple example part of Issue #533
Signed-off-by: Rob Dolin robdolin@microsoft.com