New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete some errant apostrophes. #592
Conversation
index.html
Outdated
browsing context</a>' <code>Document</code>'s metadata to | ||
populate an <a>installation process</a>' UI. | ||
browsing context</a> <code>Document</code>'s metadata to populate | ||
an <a>installation process</a> UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should read "populate the installation process's UI" (i.e., s/an/the) because the installation process was already instantiated by Step 2.1.
I think the apostrophe here was the author following Rule 1c here: "Some writers and editors add only an apostrophe to all nouns ending in s." So it is correct by some standards, but I think it's pretty unusual and better with an 's.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was indeed following Rule 1c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@marcoscaceres Do you know whether @mcgreevy needs to deal with the lpr checks before submitting this trivial change? |
No need to deal with IPR. I'll override it. |
index.html
Outdated
browsing context</a>' <code>Document</code>'s metadata to | ||
populate an <a>installation process</a>' UI. | ||
browsing context</a> <code>Document</code>'s metadata to populate | ||
an <a>installation process</a> UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mcgreevy. Sorry for the churn on such a small change. Appreciate your time. |
That's fine; I expected this change to have a big overhead:usefulness ratio; I mostly wanted to dip my toe into the water to make sure that I was able contribute to this repo as needed. |
@mcgreevy, looking forward to more contributions from you. Any questions, comments, etc. just give us a shout. |
Note: I'm not sure whether it should be:
or
but
is not right.
Preview | Diff