Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete some errant apostrophes. #592

Merged
merged 3 commits into from Aug 7, 2017
Merged

Conversation

mcgreevy
Copy link
Contributor

@mcgreevy mcgreevy commented Aug 3, 2017

Note: I'm not sure whether it should be:

installation process UI

or

installation process's UI

but

installation process' UI

is not right.


Preview | Diff

index.html Outdated
browsing context</a>' <code>Document</code>'s metadata to
populate an <a>installation process</a>' UI.
browsing context</a> <code>Document</code>'s metadata to populate
an <a>installation process</a> UI.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should read "populate the installation process's UI" (i.e., s/an/the) because the installation process was already instantiated by Step 2.1.

I think the apostrophe here was the author following Rule 1c here: "Some writers and editors add only an apostrophe to all nouns ending in s." So it is correct by some standards, but I think it's pretty unusual and better with an 's.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was indeed following Rule 1c.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree with @mgiuca - @mcgreevy, can you please make the change as @mgiuca suggests above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mgiuca
Copy link
Collaborator

mgiuca commented Aug 4, 2017

@marcoscaceres Do you know whether @mcgreevy needs to deal with the lpr checks before submitting this trivial change?

@marcoscaceres
Copy link
Member

No need to deal with IPR. I'll override it.

index.html Outdated
browsing context</a>' <code>Document</code>'s metadata to
populate an <a>installation process</a>' UI.
browsing context</a> <code>Document</code>'s metadata to populate
an <a>installation process</a> UI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree with @mgiuca - @mcgreevy, can you please make the change as @mgiuca suggests above?

@marcoscaceres
Copy link
Member

Thanks @mcgreevy. Sorry for the churn on such a small change. Appreciate your time.

@marcoscaceres marcoscaceres merged commit 07e79bc into w3c:gh-pages Aug 7, 2017
@mcgreevy
Copy link
Contributor Author

mcgreevy commented Aug 7, 2017

That's fine; I expected this change to have a big overhead:usefulness ratio; I mostly wanted to dip my toe into the water to make sure that I was able contribute to this repo as needed.

@marcoscaceres
Copy link
Member

@mcgreevy, looking forward to more contributions from you. Any questions, comments, etc. just give us a shout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants