Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Ignore any icon with no recognised purpose. #741

Merged
merged 7 commits into from
Dec 12, 2018
Merged

Breaking: Ignore any icon with no recognised purpose. #741

merged 7 commits into from
Dec 12, 2018

Commits on Nov 15, 2018

  1. Breaking: Ignore any icon with no recognised purpose. 

    Previously, if all of an icon's purposes were unrecognised, it could be
used for any purpose. This causes forwards-compatibility issues, since
if we add a new purpose (such as the recently added 'maskable'), old
user agents will interpret icons with that new purpose as 'any', which
is not intended.

Icons with no stated purpose, or whose purpose is the empty string, are
still treated as 'any'.

Closes w3c#728.
    @mgiuca
    mgiuca committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    27d7e9b View commit details
    Browse the repository at this point in the history

  2. Expand on the note about ignoring icons.

    @mgiuca
    mgiuca committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    e5ba484 View commit details
    Browse the repository at this point in the history

  3. Processing the purpose algorithm can return failure.

    @mgiuca
    mgiuca committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    1b3509f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Apply suggestions from code review 

    Co-Authored-By: mgiuca <mgiuca@chromium.org>
    @marcoscaceres @mgiuca
    marcoscaceres and mgiuca committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    28d68ec View commit details
    Browse the repository at this point in the history

  2. Tidy.

    @mgiuca
    mgiuca committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    99eea11 View commit details
    Browse the repository at this point in the history

  3. Remove linking for discussion words.

    @mgiuca
    mgiuca committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    d1cac04 View commit details
    Browse the repository at this point in the history

  4. Rephrase notes.

    @mgiuca
    mgiuca committed Nov 16, 2018
    Configuration menu
    Copy the full SHA
    586d82b View commit details
    Browse the repository at this point in the history