Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken specs #815

Merged
merged 15 commits into from Oct 16, 2019
Merged

Fix broken specs #815

merged 15 commits into from Oct 16, 2019

Conversation

janiceshiu
Copy link
Contributor

@janiceshiu janiceshiu commented Oct 15, 2019

Fixes some of the issues in #735

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:

@marcoscaceres I've opened index.html locally on this branch. There are no errors. There are some specs that I could not find in xref and removing them resulted in errors. Thus, I have left them in. I've PMed the list to you.

Please let me know what to do next. Thanks!


Preview | Diff

@marcoscaceres marcoscaceres self-requested a review October 16, 2019 00:26
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great... couple of suggestions and just needs a tidy with HTML5 tidy.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

Marcos Cáceres and others added 2 commits October 16, 2019 11:39
`xref: "web-platform"` alredy handles it

Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
index.html Outdated
@@ -907,7 +907,7 @@ <h2>
unexpected behavior, use a scope ending in a <code>/</code>.
</div>
<p>
If the <a>application context</a>'s <a data-cite="html">active document</a>'s <a data-cite=
If the <a>application context</a>'s <a>active document</a>'s <a data-cite=
"DOM#concept-document-url">URL</a> is not <a data-lt=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, could you please change this one to [=Document/URL=]

janiceshiu and others added 3 commits October 16, 2019 18:34
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@marcoscaceres marcoscaceres merged commit f069568 into w3c:gh-pages Oct 16, 2019
christianliebel pushed a commit to christianliebel/manifest that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants