Editorial: Cite Image Resource #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianliebel
requested review from
aarongustafson,
marcoscaceres and
rayankans
christianliebel
force-pushed
the
image-resource
branch
from
146ffa9
to
4964c96
Compare
aarongustafson
approved these changes
Jun 5, 2020
|
Looks good to me as well. I'm wondering if |
Could we see |
|
The new monochrome purpose could be preferred by some Android launchers I think |
|
The maskable purpose could also be preferred for full-bleed shortcut images, such as those for contacts: |
index.html
Outdated
| @@ -1139,11 +1139,11 @@ <h3> | |||
| <var>manifest</var>["<a>categories</a>"]. | |||
| </li> | |||
| <li>Set <var>manifest</var>["<a>icons</a>"] to the result of running | |||
| <a>processing ImageResource members</a> given | |||
| <a>processing ManifestImageResource members</a> given | |||
There was a problem hiding this comment.
Suggested change
| <a>processing ManifestImageResource members</a> given | |
| <a>processing `ManifestImageResource` members</a> given |
index.html
Outdated
| <var>manifest</var>["<a>icons</a>"] and <var>manifest URL</var>. | ||
| </li> | ||
| <li>Set <var>manifest</var>["<a>screenshots</a>"] to the result of | ||
| running <a>processing ImageResource members</a> given | ||
| running <a>processing ManifestImageResource members</a> given |
There was a problem hiding this comment.
Suggested change
| running <a>processing ManifestImageResource members</a> given | |
| running <a>processing `ManifestImageResource` members</a> given |
index.html
Outdated
| or to integrate the web application with an <abbr title= | ||
| "operating system">OS</abbr>'s task switcher and/or system | ||
| preferences. | ||
| <a>ManifestImageResource</a>s that can serve as iconic |
There was a problem hiding this comment.
Suggested change
| <a>ManifestImageResource</a>s that can serve as iconic | |
| {{ManifestImageResource}}s that can serve as iconic |
index.html
Outdated
| @@ -1528,7 +1528,7 @@ <h3> | |||
| examination, to in fact be inappropriate (e.g. because its content | |||
| type is unsupported), then the user agent MUST try the | |||
| next-most-appropriate icon as determined by examining the | |||
| <a>ImageResource</a>'s members. | |||
| <a>ManifestImageResource</a>'s members. | |||
There was a problem hiding this comment.
Suggested change
| <a>ManifestImageResource</a>'s members. | |
| {{ManifestImageResource}}'s members. |
index.html
Outdated
| @@ -1891,8 +1891,8 @@ <h3> | |||
| </h3> | |||
| <p> | |||
| The <dfn>screenshots</dfn> member is an <a>array</a> of | |||
| <a>ImageResource</a>s, representing the web application in common | |||
| usage scenarios. | |||
| <a>ManifestImageResource</a>s, representing the web application in | |||
There was a problem hiding this comment.
Suggested change
| <a>ManifestImageResource</a>s, representing the web application in | |
| {{ManifestImageResource}}s, representing the web application in |
index.html
Outdated
| agent can use these values to select an image that is best suited to | ||
| display on the end-user's device or most closely matches the end-user's | ||
| preferences. | ||
| Each <a>ManifestImageResource</a> represents an image that is used as |
There was a problem hiding this comment.
Suggested change
| Each <a>ManifestImageResource</a> represents an image that is used as | |
| Each {{ManifestImageResource}} represents an image that is used as |
index.html
Outdated
Comment on lines
2420
to
2422
| <li>Let |image| be the result of running [=process an image | ||
| resource from JSON|processing an image resource from JSON=] given | ||
| |entry| and |manifest URL|. |
There was a problem hiding this comment.
Suggested change
| <li>Let |image| be the result of running [=process an image | |
| resource from JSON|processing an image resource from JSON=] given | |
| |entry| and |manifest URL|. | |
| <li>Let |image| be the result of running [=process an image resource from JSON=] given | |
| |entry| and |manifest URL|. |
marcoscaceres
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #854
This change (choose one):
changes normative sections without changing behavior)
Commit message:
Cite the Image Resource spec.
Preview | Diff