Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update PULL_REQUEST_TEMPLATE.md #916

Merged
merged 5 commits into from
Jul 10, 2020
Merged

chore: update PULL_REQUEST_TEMPLATE.md #916

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d652c5d
chore: update PULL_REQUEST_TEMPLATE.md
Jul 8, 2020
0c42f42
Update PULL_REQUEST_TEMPLATE.md
Jul 9, 2020
e1e307a
Better link
Jul 9, 2020
d64dbd0
Small word fix
Jul 9, 2020
6fed633
Suggestion from Tantek
Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 10 additions & 7 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
Closes #???

This change (choose one):
This change (choose at least one, delete ones that don't apply):

* [ ] Breaks existing normative behavior (please add label "breaking")
* [ ] Adds new normative requirements
* [ ] Adds new normative recommendations or optional items
* [ ] Makes only editorial changes (only changes informative sections, or
changes normative sections without changing behavior)
* [ ] Is a "chore" (metadata, formatting, fixing warnings, etc).
* Breaks existing normative behavior (please add label "breaking")
* Adds new normative requirements
* Adds new normative recommendations or optional items
* Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)
* Is a "chore" (metadata, formatting, fixing warnings, etc).

Implementation commitment (delete if not making normative changes):

Expand All @@ -16,6 +15,10 @@ Implementation commitment (delete if not making normative changes):
* [ ] Firefox (link to issue)
* [ ] Edge (public signal)

If change is normative, and it adds or changes a member:

* [ ] [updated JSON schema](https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/web-manifest.json)

Commit message:

(Fill in. If making normative changes, describe exactly what the behavioral
Expand Down