Editorial: Created explicit algorithm for choosing display mode, and add extension point for the display_override incubation. #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurph
changed the title
mgiuca
approved these changes
Feb 8, 2021
index.html
Outdated
| mode</a>'s <a>fallback display mode</a>. This creates a fallback chain, | ||
| with the <a>default display mode</a> (<code>browser</code>) being the | ||
| last item in the chain. | ||
| The <dfn>fallback chain</dfn> for: |
There was a problem hiding this comment.
Historical note: The old text here was wrong (or rather, nonsensical):
If the user agent does support a fallback display mode, then it checks to see if it can use that display mode's fallback display mode.
This should have read "If the user agent does not support a given display mode, then it checks to see if it can use that display mode's fallback display mode."
This new text will help clarify it greatly. It might be worth adding a note to the commit message that this actually fixes broken text around how to deal with an unsupported display mode, even though we don't expect it to change implementations since we're preserving the intention behind the old broken text.
dmurph
force-pushed
the
display-override-editorial
branch
from
5201ed2
to
46466c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change (choose at least one, delete ones that don't apply):
Commit message:
Editorial: Created explicit algorithm for choosing display mode, and add extension point for the display_override incubation.
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:
Preview | Diff