Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-publish.yml #146

Merged
merged 1 commit into from
May 3, 2022
Merged

auto-publish.yml #146

merged 1 commit into from
May 3, 2022

Conversation

davidcarlisle
Copy link
Collaborator

This PR makes no changes to the spec but enables a github action to leave an exported respec snapshot as spec.html in addition to the existing "live" respec source as index.html

For discussion of this see the issue at the main MathML4 repo w3c/mathml#329

@davidcarlisle
Copy link
Collaborator Author

If this is merged github pages will need to be set in the github UI to be built from the gh-pages branch, leaving main still the default branch for edits and pull requests.

@NSoiffer
Copy link
Contributor

I tried the "respec"-less document with NVDA and it reads well. There's no MathML in it as far as I saw, so I can't test that. The little bit of navigation commands that I know all worked properly.

@ljmaher
Copy link

ljmaher commented Apr 28, 2022 via email

Copy link
Contributor

@bert-github bert-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@davidcarlisle davidcarlisle merged commit 3c93ffa into w3c:main May 3, 2022
@davidcarlisle
Copy link
Collaborator Author

@bert-github thanks, this is merged and github pages now builds off the gh-pages branch which should be (just) used by the gh action. The results are live now with

exported version, spec.html

https://w3c.github.io/mathml-core/spec.html

live respec version default, index.html

https://w3c.github.io/mathml-core/

@NSoiffer
Copy link
Contributor

NSoiffer commented May 3, 2022

FYI: Chrome says (of spec.html):

A page or script is accessing at least one of navigator.userAgent, navigator.appVersion, and navigator.platform. Starting in Chrome 101, the amount of information available in the User Agent string will be reduced.
To fix this issue, replace the usage of navigator.userAgent, navigator.appVersion, and navigator.platform with feature detection, progressive enhancement, or migrate to navigator.userAgentData.

@davidcarlisle
Copy link
Collaborator Author

@NSoiffer might be better to move that to an issue: could get lost in a closed PR. I don't think that's me, I'll check where it's coming from and raise at respec if needed.

@davidcarlisle
Copy link
Collaborator Author

@NSoiffer hmm I don't get that warning in my chrome console and the only instance of navigator.anything I can find is in the linked tables/sorttable.js that has

// /* for Safari */
// if (/WebKit/i.test(navigator.userAgent)) { // sniff
//     var _timer = setInterval(function() {
//         if (/loaded|complete/.test(document.readyState)) {
//             sorttable.init(); // call the onload handler
//         }
//     }, 10);
// }

ie in a comment, If you have a local server running could you test with that comment removed?

@NSoiffer
Copy link
Contributor

NSoiffer commented May 3, 2022

Open the Chrome debugger:

image

You don't need to run the audit (I think).

@davidcarlisle
Copy link
Collaborator Author

@NSoiffer that's where I looked:-)

That's chrome Version 100.0.4896.127 (Official Build) (64-bit)

and chrome canary Version 103.0.5040.0 (Official Build) canary (64-bit)

image

@NSoiffer
Copy link
Contributor

NSoiffer commented May 4, 2022

The best kind of problems are those that go away with no work :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants