Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical stretchy rule: Define what happens when maxsize < minsize #109

Closed
fred-wang opened this issue Jul 5, 2019 · 7 comments
Closed

Vertical stretchy rule: Define what happens when maxsize < minsize #109

fred-wang opened this issue Jul 5, 2019 · 7 comments
Labels
MathML Core Issues affecting the MathML Core specification MathML 4 Issues affecting the MathML 4 specification

Comments

@fred-wang
Copy link

I think this is what Bruce actually wanted to mention this during one the mstyle@minsize discussion.

If maxsize < minsize then one can only satisfy one of the constraint. In Gecko it was implemented so that the minsize is satisfied. As a consequence, I implemented the same in WebKit.

However, maybe maxsize < minsize should just be treated as an invalid request and hence ignored?
@fred-wang fred-wang added MathML 4 Issues affecting the MathML 4 specification MathML Core Issues affecting the MathML Core specification need resolution Issues needing resolution at MathML Refresh CG meeting need implementation update need polyfill Issues requiring implementation changes need specification update Issues requiring specification changes need tests Issues related to writing WPT tests labels Jul 5, 2019
@fred-wang fred-wang mentioned this issue Aug 22, 2019
Closed
@NSoiffer
Copy link
Contributor

NSoiffer commented Oct 7, 2019

FYI: MathPlayer handled this by setting minsize to maxsize (i.e, it basically choose maxsize).

@fred-wang
Copy link
Author

From Monday meeting: check similar behavior in CSS.

@fred-wang
Copy link
Author

fred-wang commented Oct 14, 2019 •
edited

From Monday meeting: check similar behavior in CSS.

CSS always respects the minsize, so we should do the same (i.e. maxsize set to minsize) for MathML

@fred-wang
Copy link
Author

Consensus from 2019/11/11: keep as it i.e. do like CSS (minsize wins over maxsize)

@fred-wang fred-wang removed the need specification update Issues requiring specification changes label Nov 12, 2019
fred-wang added a commit to w3c/mathml-core that referenced this issue May 9, 2020
@fred-wang
Remove ISSUE 109 tag, since it was resolved to keep the spec as it.
1d605b8 
w3c/mathml#109

Not closing as this likely still need tests.
@NSoiffer
Copy link
Contributor

This has "needs polyfill" label, but I don't see why, so I'm removing it. In fact, I think only the 'needs tests' label is all that should remain. @fred-wang: can you verify and update the labels if this is true.

@NSoiffer NSoiffer removed the need polyfill Issues requiring implementation changes label May 18, 2020
@fred-wang
Copy link
Author

@NSoiffer I think the original idea was to put all the labels when an issue is opened and then let people check and remove them. But in that case, I agree that's no longer needed.

@NSoiffer
Copy link
Contributor

I'm removing the 'needs resolution' since we have a resolution.

@NSoiffer NSoiffer removed the need resolution Issues needing resolution at MathML Refresh CG meeting label May 19, 2020
fred-wang added a commit to w3c/mathml-core that referenced this issue May 22, 2020
@fred-wang
normalize minsize and maxsize before using them
9075ff0 
w3c/mathml#109
fred-wang added a commit to web-platform-tests/wpt that referenced this issue May 22, 2020
@fred-wang
Add MathML test for edge cases of minsize and maxsize
5cb6ec5 
w3c/mathml#109
@fred-wang fred-wang mentioned this issue May 22, 2020
Merged
fred-wang added a commit to web-platform-tests/wpt that referenced this issue May 23, 2020
@fred-wang
Add MathML test for edge cases of minsize and maxsize (#23743)
d7ba3d5 
* Add MathML test for edge cases of minsize and maxsize

w3c/mathml#109

* fix title
@fred-wang fred-wang removed the need tests Issues related to writing WPT tests label May 23, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 27, 2020
@fred-wang @moz-wptsync-bot
Bug 1640207 [wpt PR 23743] - Add MathML test for edge cases of minsiz…
b5f937c 
…e and maxsize, a=testonly

Automatic update from web-platform-tests
Add MathML test for edge cases of minsize and maxsize (#23743)

* Add MathML test for edge cases of minsize and maxsize

w3c/mathml#109

* fix title
--

wpt-commits: d7ba3d542968b63ddba6f809c5bbeba3d99cf2cb
wpt-pr: 23743
xeonchen pushed a commit to xeonchen/gecko that referenced this issue May 27, 2020
@fred-wang @moz-wptsync-bot
Bug 1640207 [wpt PR 23743] - Add MathML test for edge cases of minsiz…
c24c011 
…e and maxsize, a=testonly

Automatic update from web-platform-tests
Add MathML test for edge cases of minsize and maxsize (#23743)

* Add MathML test for edge cases of minsize and maxsize

w3c/mathml#109

* fix title
--

wpt-commits: d7ba3d542968b63ddba6f809c5bbeba3d99cf2cb
wpt-pr: 23743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MathML Core Issues affecting the MathML Core specification MathML 4 Issues affecting the MathML 4 specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fred-wang @NSoiffer