Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/Remove merror #70

Closed
fred-wang opened this issue Mar 5, 2019 · 9 comments
Closed

Deprecate/Remove merror #70

fred-wang opened this issue Mar 5, 2019 · 9 comments
Labels
MathML Core Issues affecting the MathML Core specification

Comments

@fred-wang
Copy link

Opening this to discuss whether we should deprecate/remove merror from MathML core/full.

It seems to me generally people won't publish content with errors, unless they were generated from e.g. LaTeX or Computer Algebra system.

@fred-wang
Copy link
Author

fred-wang commented Mar 14, 2019

My understanding of the status is that

  • We would keep it in MathML Core defined as an mrow algo with additional style
  • Is the suggested merror { outline: solid thin red; background-color: lightYellow; } what we want?
  • Borders will require CSS margin/border/padding compatibility #14

@davidcarlisle
Copy link
Collaborator

That looks good to me.

@fred-wang fred-wang added MathML Core Issues affecting the MathML Core specification MathML 4 Issues affecting the MathML 4 specification compatibility Issues affecting backward compatibility labels Mar 18, 2019
@fred-wang fred-wang added the need resolution Issues needing resolution at MathML Refresh CG meeting label May 16, 2019
@fred-wang
Copy link
Author

Resolved on 2019/06//03 as in #70 (comment)
Core spec has been updated: https://mathml-refresh.github.io/mathml-core/#merror

@fred-wang fred-wang added need implementation update need specification update Issues requiring specification changes need tests Issues related to writing WPT tests and removed need resolution Issues needing resolution at MathML Refresh CG meeting need specification update Issues requiring specification changes labels Jun 4, 2019
@NSoiffer NSoiffer removed compatibility Issues affecting backward compatibility MathML 4 Issues affecting the MathML 4 specification MathML Core Issues affecting the MathML Core specification need tests Issues related to writing WPT tests labels Feb 24, 2020
@NSoiffer NSoiffer added the need tests Issues related to writing WPT tests label Feb 24, 2020
@NSoiffer
Copy link
Contributor

Only remaining thing is to write a test to make sure style sheet (color, etc) is being implemented.

@fred-wang fred-wang added MathML Core Issues affecting the MathML Core specification need resolution Issues needing resolution at MathML Refresh CG meeting need specification update Issues requiring specification changes labels May 22, 2020
@fred-wang
Copy link
Author

cc @rwlbuis

Adding back mathml core label since we still need to write tests. I think we have tests but they follow chromium's style which I'm not sure is aligned on the spec.

Also reputting need resolution and spec update in case people want to bikeshed on the "Is the suggested merror { outline: solid thin red; background-color: lightYellow; } what we want?"

@bkardell
Copy link
Collaborator

This doesn't seem worth bikeshedding as it is at best a suggestion. I'm not sure how there could be something nomative in that? Could there?

@fred-wang
Copy link
Author

well, we just need to decide something to put in the UA stylesheet. If everybody is ok with "merror { outline: solid thin red; background-color: lightYellow; } " then we can choose that.

@fred-wang fred-wang removed need resolution Issues needing resolution at MathML Refresh CG meeting need specification update Issues requiring specification changes labels May 27, 2020
@fred-wang
Copy link
Author

This doesn't seem worth bikeshedding as it is at best a suggestion. I'm not sure how there could be something nomative in that? Could there?

Also, merror affects some tests so we need to decide a default value. Authors/Users can always change it if they don't like, so I don't think the exact values matters.

Chromium has the following rules:
merror {
color: red;
background-color: lightYellow;
}

Gecko has the following rule:
merror {
display: block;
font-family: sans-serif;
font-weight: bold;
white-space: pre;
margin: 1em;
padding: 1em;
border-width: thin;
border-style: inset;
border-color: red;
font-size: 14pt;
background-color: lightyellow;
}

WebKit has this:
merror {
outline: solid thin red;
font-weight: bold;
font-family: sans-serif;
background-color: lightYellow;
}

It's better not to modify the text style and we don't really explain how to handle outline in the core spec, so a yellow background and border (with optionally padding/margin) seems best.

fred-wang added a commit to w3c/mathml-core that referenced this issue May 27, 2020
fred-wang added a commit to web-platform-tests/wpt that referenced this issue May 27, 2020
…g. (#23794)

* Update style for merror and add a basic test for the default rendering.

w3c/mathml#70

* fix bad markup
@fred-wang fred-wang removed the need tests Issues related to writing WPT tests label May 27, 2020
@fred-wang
Copy link
Author

test added

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 1, 2020
…test for the default rendering., a=testonly

Automatic update from web-platform-tests
Update style for merror and add a basic test for the default rendering. (#23794)

* Update style for merror and add a basic test for the default rendering.

w3c/mathml#70

* fix bad markup
--

wpt-commits: a1bdc5baa9295e462601d2e8631471ef4075b7c1
wpt-pr: 23794
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jun 2, 2020
…test for the default rendering., a=testonly

Automatic update from web-platform-tests
Update style for merror and add a basic test for the default rendering. (#23794)

* Update style for merror and add a basic test for the default rendering.

w3c/mathml#70

* fix bad markup
--

wpt-commits: a1bdc5baa9295e462601d2e8631471ef4075b7c1
wpt-pr: 23794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MathML Core Issues affecting the MathML Core specification
Projects
None yet
Development

No branches or pull requests

4 participants