This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Remove depth map calibration parameters #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented experiments [1] showed that: * Application could be responsible to provide the values based on camera name, with no need to obtain the values from hardware. * There is no standardized approach to obtain the calibration parameters, by browser from hardware. This simplifies the specification and makes it in line with already implemented (in Blink) videoKind property. [1] https://github.com/01org/depth-camera-web-demo
|
@anssiko |
anssiko
suggested changes
Feb 28, 2019
anssiko
suggested changes
Feb 28, 2019
|
Thanks. Removed them and MediaVideoElement and Float32Array, too - they were used in non-normative, code examples, only. |
|
LGTM. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented experiments [1] showed that:
on camera name, with no need to obtain the values from hardware.
parameters, by browser from hardware.
This simplifies the specification and makes it in line with already
implemented (in Blink) videoKind property.
[1] https://github.com/01org/depth-camera-web-demo
Preview | Diff