Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhotoCapabilities::autoWhiteBalanceMode is a MediaSettingsItem, could be boolean #14

Closed
yellowdoge opened this issue Apr 1, 2016 · 2 comments

Comments

@yellowdoge
Copy link
Member

In [1] , autoWhiteBalanceMode is described as:

This reflects whether automated White Balance Mode selection is on or off, and is boolean - on is true

So I would propose making it Boolean instead of MediaSettingsItem.

The equivalent autoWhiteBalanceMode setting in PhotoSettings [2] is a boolean.

[1] http://w3c.github.io/mediacapture-image/index.html#attributes-4
[2] http://w3c.github.io/mediacapture-image/index.html#dictionary-photosettings-members

@yellowdoge
Copy link
Member Author

Same thing for redEyeReduction in the same interface.

@gmandyam
Copy link
Collaborator

Yes, these should be Boolean types. Thanks for the catch. Have incorporated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants