Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is https://www.w3.org/TR/image-capture/#dom-mediatrackcapabilities-torch a boolean #304

Closed
youennf opened this issue Oct 4, 2023 · 1 comment · Fixed by #305
Closed

Comments

@youennf
Copy link
Contributor

youennf commented Oct 4, 2023

https://w3c.github.io/mediacapture-main/#dom-mediatrackcapabilities-echocancellation is [false], [true] or [false, true].
https://www.w3.org/TR/image-capture/#dom-mediatrackcapabilities-torch is supposed to be false or true.

It seems we should align these properties, probably torch should align with echoCancellation and other booleans like autoGainControl, noiseSuppression.

@guidou, do you know what Chrome is doing here and/or why a single bool was chosen?
@jan-ivar, thoughts?

@guidou
Copy link

guidou commented Oct 10, 2023

Chrome has it as a bool, as in the spec, but I think it should be an array.
I don't know why it was done this way, but my guess is that true actually means [false,true], given that the definition is

A boolean indicating whether camera supports torch mode- on meaning supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants