Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should getSupportedContraints be static? #66

Closed
ShijunS opened this issue Nov 8, 2014 · 2 comments
Closed

should getSupportedContraints be static? #66

ShijunS opened this issue Nov 8, 2014 · 2 comments
Assignees

Comments

@ShijunS
Copy link
Contributor

ShijunS commented Nov 8, 2014

If getSupportedContraints is "static" as in the current draft, all the examples need to be fixed.

For example,
var supports = navigator.mediaDevices.getSupportedConstraints("video");

should be changed to
var supports = MediaDevices.getSupportedConstraints("video");

@adam-be
Copy link
Member

adam-be commented Nov 12, 2014

The static function is available on the instance navigator.mediaDevices as well. But we should probably remove the "static" keyword there since we have the singelton.

@dontcallmedom
Copy link
Member

Agree we should remove the static keyword, it doesn't seem to gain us much here.

I haven't made a PR since the WebIDL in which this sits is broken, pending integration of jan-ivar/mediacapture-main@36d22bb in #37

dontcallmedom added a commit to dontcallmedom/mediacapture-main that referenced this issue Mar 10, 2015
dontcallmedom added a commit to dontcallmedom/mediacapture-main that referenced this issue Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants