Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webidl fixes #143

Closed
wants to merge 2 commits into from
Closed

Webidl fixes #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
410ff73
use MediaTrackSettings to describe the list of supported constraints
dontcallmedom Mar 10, 2015
9763842
getSupportedConstraints doesn't need to be static
dontcallmedom Mar 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions getusermedia.html
View file
Open in desktop
Expand Up @@ -3015,15 +3015,15 @@ <h3>MediaDevices Interface Extensions</h3>
recognizes.</p>

<dl class="idl" title="partial interface MediaDevices">
<dt>static Dictionary getSupportedConstraints(DOMString kind)</dt>
<dt>MediaTrackSettings getSupportedConstraints(DOMString kind)</dt>

<dd>
<p>Returns a dictionary whose members are the constrainable properties
<p>Returns an object whose members are the constrainable properties
known to the User Agent for the kind given as argument. A
supported constrainable property MUST be represented by a member whose name is
the constraint name and whose value is <code>true</code>. Any
the constraint name and whose value is truthy. Any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we nail this down to {} (with a note that it's truthy, and note that future specs may choose to return other values)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't use {} if the type is MediaTrackSettings, because the members of that dictionary are simple values, not objects.

If we adopt Jan-Ivar's suggestion of using MediaTrackConstrainttSet instead, then we can and should use the more specific {}.

constrainable properties not supported by the User Agent MUST not be
present in the returned dictionary.</p>
present in the returned object.</p>
</dd>

<dt>Promise&lt;MediaStream&gt; getUserMedia(
Expand Down