Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short descriptions of arguments to callbacks in callback-based gUM #153

Merged
merged 2 commits into from
Apr 9, 2015

Conversation

dontcallmedom
Copy link
Member

No description provided.

@alvestrand
Copy link
Contributor

Looks good to me.

@burnburn
Copy link
Contributor

burnburn commented Apr 9, 2015

These should refer to navigator.getUserMedia() rather than navigator.mediaDevices.getUserMedia() since these are only applicable to the callback version of the API. Otherwise, thanks for filling these in :)

@dontcallmedom
Copy link
Member Author

@burnburn I've used mediaDevices references on purpose — that's where the algorithms are defined nowadays.

@alvestrand
Copy link
Contributor

After talking to Dan, I think he's right. We need to point to navigator.getUserMedia for the procedure, because that's where we define what the argument for the callback is - the mediaDevices.getUserMedia definition talks about resolving a promise.

@dontcallmedom
Copy link
Member Author

ok, will update

burnburn added a commit that referenced this pull request Apr 9, 2015
short descriptions of arguments to callbacks in callback-based gUM
@burnburn burnburn merged commit 6540ac9 into w3c:master Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants