Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 26654 (Webidl in Constrainable + ConstrainBooleanParameters + nits) #22

Closed
wants to merge 1 commit into from

Conversation

@fluffy
Copy link
Contributor

fluffy commented Sep 24, 2014

Hmm - not sure this look right. I think the plan was settings were a different type than constraints as defined in section 11.4.

@jan-ivar
Copy link
Member Author

This PR updates 11.4. to reflect that "Settings is a bare-values-only subset of a ConstraintSet dictionary" [1], as requested in the bug [2] with the sentence "We're leaving the reader to deduce that Settings is a bare-values-only subset of ConstraintSet. IMHO prose and examples are no substitute for definitions." to which Harald replied "[...] Agreed that we need to be explicit." [3]

11.5 says "[MediaTrackConstraints and MediaTrackConstraintSet] must provide their own definitions that follow this pattern."

Which this does. Do we really need to define a bare-values-only subset of MediaTrackConstraintSet when we've already said that UAs MUST fill it with bare values, and no webpage will ever be able to tell the difference?

It seems to me we've taken greater liberties in the past to avoid duplication like this (e.g. VideoTrackConstraints vs. AudioTrackConstraints).

[1] http://htmlpreview.github.io/?https://raw.githubusercontent.com/jan-ivar/mediacapture-main/constrainable/getusermedia.html#settings
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=26654#c0
[3] http://lists.w3.org/Archives/Public/public-media-capture/2014Aug/0148.html

@burnburn
Copy link
Contributor

burnburn commented Oct 9, 2014

Jan-Ivar, the editor team reviewed this and would prefer that it be split into two pull requests:

  • first should contain ConstrainBoolean and ConstrainDOMString and typos (which we agree are ready to go in), and
  • second should contain your proposed changes to using MediaTrackConstraintSet everywhere, which may need more discussion.

Can you please do that?

@jan-ivar
Copy link
Member Author

jan-ivar commented Oct 9, 2014

Split this PR into two on request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants