Remove static like definitions of attributes and methods #235
Conversation
…am and MediaStreamTrack
|
LGTM. |
|
Pushed an additional commit that removes wording like MediaDevices.getUserMedia(). |
|
Does anyone have a problem with this PR? If not I think we should merge it. As I read it the changes are only editorial. |
| @@ -449,7 +449,7 @@ | |||
| to that string. A good practice is to use a UUID [[rfc4122]], which | |||
| is 36 characters long in its canonical form.</p> | |||
|
|
|||
| <p>The <dfn id="dom-mediastream-id"><code>id</code></dfn> attribute | |||
| <p>The <dfn data-lt-noDefault id="dom-mediastream-id"><code>id</code></dfn> attribute | |||
There was a problem hiding this comment.
Fyi, there's another 'id' in the paragraph above this one that you missed (the two now look different). I also wonder if this could be rewritten to avoid the double mention (let alone single mention).
There was a problem hiding this comment.
Are you referring to the id link in the paragraph above? Since it's a link, and the highlighted text is the definition, they need to look different.
There was a problem hiding this comment.
(whoops, missed some comments. Thanks github and outdated diff!)
Makes sense now. I was probably expecting this paragraph (with definition) to come before the other.
|
@jan-ivar, can you take a look at the latest changes? |
|
lgtm! |
Remove static like definitions of attributes and methods
Fixed for MediaStream and MediaStreamTrack