New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"If sinkId and the sinkId attribute are the same object, return a resolved promise." #40

Closed

domenic opened this issue Oct 19, 2016 · 1 comment

domenic commented Oct 19, 2016

A couple minor issues:

Neither sinkId nor the sinkId attribute are objects. sinkId is a string; the sinkId attribute is an attribute, but the sinkId's attribute's value is a string.
Resolved with what? "a promise resolved with undefined" is probably what you want here.

Author

domenic commented Oct 19, 2016

The "resolved with what" problem also occurs at the end of the setSinkId algorithm.

guidou mentioned this issue

Update text in algorithm sections #52

Merged

guidou closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment