New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeslice should not be signed #155

Closed

youennf opened this issue Oct 30, 2018 · 0 comments

Contributor

youennf commented Oct 30, 2018

timeslice is a number of milliseconds and it does not make sense to have a negative number.
Can we make it unsigned long instead of long?

yellowdoge mentioned this issue

Make MediaRecorder's start() parameter |timeslice| unsigned #159

Merged

yellowdoge closed this as completed in

c34a152

Pehrsons mentioned this issue

(Editorial) Make timeslice unsigned everywhere #174

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment