Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaRecorderErrorEvent is a bad idea; use ErrorEvent instead #211

Closed
domenic opened this issue Jan 12, 2022 · 4 comments · Fixed by #212
Closed

MediaRecorderErrorEvent is a bad idea; use ErrorEvent instead #211

domenic opened this issue Jan 12, 2022 · 4 comments · Fixed by #212

Comments

@domenic
Copy link

domenic commented Jan 12, 2022

ErrorEvent already exists and serves this purpose fine. We shouldn't propagate multiple such types on the web platform.

@alvestrand
Copy link
Contributor

MDN claims that Firefox and Safari implement MediaRecorderErrorEvent (https://developer.mozilla.org/en-US/docs/Web/API/MediaRecorderErrorEvent#methods)

WPT.FYI seems to indicate that only Firefox does: https://wpt.fyi/results/mediacapture-record/idlharness.window.html?label=experimental&label=master&aligned

@domenic
Copy link
Author

domenic commented Jan 12, 2022

Oh, thanks, I thought it was nobody else since the blink-dev Intent to Prototype indicated no signals from other browsers...

I think this would likely be a backward-compatible change for Firefox since event.error would still exist and return the same value. The only thing that would break is if someone is doing new MediaRecorderErrorEvent(...) which seems pretty unlikely.

dontcallmedom added a commit to dontcallmedom/mediacapture-record that referenced this issue Jan 14, 2022
dontcallmedom added a commit to dontcallmedom/web-platform-tests that referenced this issue Jan 14, 2022
@dontcallmedom
Copy link
Member

looking on github and on searchcode, the only occurrences of new MediaRecorderErrorEvent() seems to be in WPT.

I've filed #212 for a spec change, and drafted web-platform-tests/wpt#32380 for the associated WPT changes.

@foolip
Copy link
Member

foolip commented Jan 20, 2022

I've done a search for "MediaRecorderErrorEvent." (trailing dot) in httparchive and there were only 4 matches. All 4 of those look like generated stuff from IDL or some other API listing. https://documents.devdocs.io/dom/index.json?1634928100 is one example, which I think is a mapping of features to MDN pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants