Changed constructor mimeType with a MediaRecorderOptions dictionary #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also hopefully addresses #20. |
|
Seeing that there's little comments here or in the mailing list, I'm going to land and close this pull request, seeing that is mostly a catch-up with the current Gecko implementation. |
yellowdoge
added a commit
that referenced
this pull request
Dec 10, 2015
…ictionary Changed constructor mimeType with a MediaRecorderOptions dictionary
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first go at changing the constructor argument |mimeType| with a dictionary of Options, re #19.
As mentioned in this issue, this patch is basically taking in Gecko implementation, and Blink has a CL ready to update to it.