Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete note (name of CropTarget) #53

Closed
wants to merge 1 commit into from
Closed

Remove obsolete note (name of CropTarget) #53

wants to merge 1 commit into from

Conversation

eladalon1983
Copy link
Member

@eladalon1983 eladalon1983 commented May 31, 2022 •
edited by pr-preview bot

Fixes #18.
I believe the discussion over names and bespoke IDs vs. single-purpose IDs is now complete.

Preview | Diff

@eladalon1983
Copy link
Member Author

@jan-ivar and @youennf, PTAL.

@eladalon1983 eladalon1983 mentioned this pull request May 31, 2022
Merged
@eladalon1983
Copy link
Member Author

Can we merge this? The consensus during the interim was to keep CropTarget.
@aboba @youennf @jan-ivar

@eladalon1983
Copy link
Member Author

eladalon1983 commented Oct 20, 2022 •
edited

It appears that this was a dupe of #73. My apologies for not realizing this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-ivar jan-ivar Awaiting requested review from jan-ivar

@youennf youennf Awaiting requested review from youennf

Assignees
No one assigned
Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is CropTarget name too generic?
2 participants
@eladalon1983 @alvestrand