Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single enum for or all #277

Closed
beaufortfrancois opened this issue Sep 1, 2023 · 1 comment
Closed

Use a single enum for or all #277

beaufortfrancois opened this issue Sep 1, 2023 · 1 comment

Comments

@beaufortfrancois
Copy link
Contributor

May I suggest we use single Enum for "include", "exclude" and use it where needed?

Before:

enum SelfCapturePreferenceEnum {
  "include",
  "exclude"
};
enum SystemAudioPreferenceEnum {
  "include",
  "exclude"
};
enum SurfaceSwitchingPreferenceEnum {
  "include",
  "exclude"
};
enum MonitorTypeSurfacesEnum {
  "include",
  "exclude"
};
enum DisplayMediaIncludeOrExclude { "include", "exclude" };

typedef DisplayMediaIncludeOrExclude SystemAudioPreferenceEnum;
typedef DisplayMediaIncludeOrExclude SelfCapturePreferenceEnum;
typedef DisplayMediaIncludeOrExclude SurfaceSwitchingPreferenceEnum;
typedef DisplayMediaIncludeOrExclude MonitorTypeSurfacesEnum;
@jan-ivar
Copy link
Member

Closing as a dup of #278

@jan-ivar jan-ivar closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants