Added DisplaySurfaceChangeCallback #289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -490,7 +502,8 @@ <h2><dfn>MediaDevices</dfn> Additions</h2> | |||
| <li> | |||
| <p>This invocation of {{MediaDevices/getDisplayMedia()}} is | |||
| now considered to have produced a new | |||
| <dfn>capture-session</dfn>.</p> | |||
| <dfn>capture-session</dfn>, with the associated | |||
| [=capture-source-set=], <var>sources</var>.</p> | |||
| </li> | |||
There was a problem hiding this comment.
Should the part below, which dealt with controller.[[Source]], be updated to reference the video source from capture-source-set rather than (as it does now) the "video track's source"?
(GitHub didn't let me attach this comment in the desired location.)
| The user agent MUST NOT change the [=display surface=] | ||
| associated with a [=capture-session=] unless the user has | ||
| explicitly indicated that they want this change to be | ||
| performed by interacting with user agent or operating system. |
There was a problem hiding this comment.
nit: Could you make editorial changes here so as to discourage anyone from misreading "by interacting" as binding to the wrong part of the sentence? Maybe "...performed. Users can do this by interacting with..."
| <li> | ||
| <p> | ||
| Let <var>newSources</var> replace the [=capture-source-set=] | ||
| associated with the [=capture-session=] |
Comment on lines
+697
to
+701
| <li> | ||
| <p>Queue tasks to stop all tracks connected to sources in the | ||
| [=capture-source-set=] associated with the [=capture-session=]. | ||
| </p> | ||
| </li> |
There was a problem hiding this comment.
The order in the PR as it currently stands:
- Stop delivering frames.
- Queue tasks to end the old tracks.
- Synchronously make changes to internal slots.
- Synchronously invoke the callback.
Perhaps it should be:
- Stop delivering frames.
- Queue task to:
a. Make changes to internal slots.
b. Invoke the callback. - Queue tasks to end the old tracks.
Wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes w3c/mediacapture-screen-share-extensions#4.
Preview | Diff