Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type of MediaMetadata's artwork #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Oct 11, 2019

  1. Update type of MediaMetadata's artwork

    Since the entries in the MediaMetadata's `artwork` are frozen in the
    current spec [1], the type of the attribute `artwork` must be
    `FrozenArray<object>` rather than `FrozenArray<MediaImage>`. Otherwise
    the entries of artwork can not be frozen [2]. This change will address
    issue w3c#237
    
    The `artwork` in `MediaMetadataInit` and `MediaMetadata` will be clearly
    different after changing the `artwork` in `MediaMetadata` to
    `FrozenArray<object>`, hence the _getter_, _setter_ of `artwork` and the
    _convert artwork algorithm_ should be updated to match the change. This
    change will address issue w3c#176
    
    [1] https://github.com/web-platform-tests/wpt/blob/801a2b3b5e1cd0192f31890ddf9ee7b4d0ad9e89/mediasession/mediametadata.html#L148
    [2] https://tc39.es/ecma262/#sec-object.freeze
    ChunMinChang committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    e561ec3 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Configuration menu
    Copy the full SHA
    0403825 View commit details
    Browse the repository at this point in the history