This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
add i18n, privacy and security considerations #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good for a first release. Perhaps we could say a little more about privacy considerations in future tweaks? Also should we cross-link issues like #4 where appropriate, to channel feedback? Merging as these are observations not blockers and time is tight. |
|
We can and probably should tweak the sections further. In any event, I think we should be asking for review of these aspects. Most of the technical stuff is in place - it's just a case of testing if it works, and is clearly explained. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12
fix #13
all of these need review from the relevant groups.