Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify relationship to Web Application Manifest #54

Closed
pes10k opened this issue Aug 9, 2022 · 3 comments · Fixed by #59
Closed

Clarify relationship to Web Application Manifest #54

pes10k opened this issue Aug 9, 2022 · 3 comments · Fixed by #59
Assignees
Labels
privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response.

Comments

@pes10k
Copy link

pes10k commented Aug 9, 2022

This issue is being filed as part of of PING's horizontal review

The substance of the proposal and its intended use cases are similar to the Web Application Manifest proposal (describing a packaged web or web-like application). It would be ideal to combine these in some way, specify one as an extension to the other, or otherwise remove the complexity of two different nearly-but-not-identical proposals.

If thats not possible, it would be good to at least have some non-normative text in this proposal explaining the relationship of the two specs and (possibly) why they need to be mostly-identical-but-fully-independent specs

This is not a blocking privacy issue, but I'm mentioning it since it came up during the review

@pes10k pes10k added the privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. label Aug 9, 2022
@espinr espinr self-assigned this Aug 16, 2022
@espinr
Copy link
Collaborator

espinr commented Sep 8, 2022

In #59 , I've included a text to clarify the relationship.

Pasting the content for an easier review:

This specification defines the set of metadata to describe MiniApps, extending the [[[APPMANIFEST]]] and the [[[MANIFEST-APP-INFO]]] by providing additional mechanisms to describe and set up MiniApps. The MiniApp Manifest directly reuses essential elements from these specifications (i.e., name, short_name, description, and icons), adding supplementary members that specifically affect MiniApps (e.g., app_id, version, platform_version, device_type, pages, req_permissions, and widgets) and their look and feel (e.g., color_scheme and window).

@pes10k
Copy link
Author

pes10k commented Sep 10, 2022

Hi @espinr , i think those are good changes. If this spec is designed to augment / suplement AppManifest, then it'd be ideal to only define those suplements / additions in your spec, instead of effectively inlining the entire AppManifest spec. Woudl that be possible?

@espinr
Copy link
Collaborator

espinr commented Sep 12, 2022

Yes, you are right @pes10k. It makes sense.
Historically, this manifest has included all the members, and we've kept them as a Web App manifest profile. We need to mention those members reused from the Web App Manifest because this document introduces some constraints to the Web App Manifest members (some are mandatory in this spec). But, you are right that we don't need to re-define all of them in the specification if we just reuse them. I suppose we can just refer to the original definition.

In the meantime, I've added that this spec introduces constraints to the Web App Manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants