Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of explainer (+ 2 members) #47

Merged
merged 29 commits into from
Apr 28, 2022
Merged

Update of explainer (+ 2 members) #47

merged 29 commits into from
Apr 28, 2022

Conversation

espinr
Copy link
Collaborator

@espinr espinr commented Mar 28, 2022 •
edited
Loading

Closes #30

This change:

  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

Commit message:

Explained updated to add the rationale behind the updates in the specification.
In concrete, updating the texts and including the device_type and color_scheme members, and updating the platform_version and version members.

Preview | Diff

@espinr
Example consistent with Packaging spec
3f18145 
(reported on w3c#35)
@espinr
Clarification of pages member (file extension)
9398e73
@espinr
pages member example as relative directory
57b8bfa
@espinr
new note encoraging the use of label in icons
191cf22
@espinr
Included accessibility considerations
fd68f2d
@espinr
Removed title case for consistency
2ac6f54
@espinr
Informative section
f1f520e
@espinr
Merge branch 'main' of https://github.com/w3c/miniapp-manifest into a…
51477e5 
…11y-section
@espinr
New sections based on the self-review form
29b452d
@espinr
Reference to JSON spec
0d3bcc3
@espinr
Mentioned the javascript: URL
2b7a751
@espinr
Ideas of indicating a CSP within the manifest
cbc48c5
@espinr
Removing the inline issue on CSP
3738e3d
@espinr
New template
40379db
@espinr
Typo fixed
dbd6afc
@espinr
Reserved words in uppercase
bd30490
@espinr
Uppercase the reserved word
b865532
@espinr
Native UI paragraph moved to accessibility section
3cb10f1
@espinr
chore: just editorial
9eff258
@espinr
chore: Duplicated member fixed
4503dcc
@espinr
Merge branch 'main' of https://github.com/w3c/miniapp-manifest into m…
f741aec 
…arkup-cleansing
@espinr
Cleaning markup (homogeneous dfns and links)
482eeb3
@espinr
Fixing markup error
93394f3
@espinr
Changed URLs from github.io to w3.org
8669a27
@espinr
Schema still under github.io
c526494
@espinr
New members in the comparison table
eacd2b7
@espinr
Editorial typos and wording refinement
7d2ad11
@espinr espinr changed the title 2 member explainer Update of explainer (+ 2 members) Mar 28, 2022
@espinr espinr mentioned this pull request Mar 28, 2022
Closed
@xfq xfq added the explainer Improvements or additions to explainer label Mar 29, 2022
@espinr
Copy link
Collaborator Author

espinr commented Apr 26, 2022

This PR closes #30 and #48

@espinr
Copy link
Collaborator Author

espinr commented Apr 26, 2022

The preview: https://github.com/espinr/miniapp-manifest/blob/2-member-explainer/docs/explainer.md

@espinr espinr mentioned this pull request Apr 26, 2022
Closed
@espinr espinr merged commit e9d24da into w3c:main Apr 28, 2022
@espinr espinr deleted the 2-member-explainer branch April 28, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
explainer Improvements or additions to explainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the explainer for color mode and device types
2 participants
@espinr @xfq