This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Use a node-based proxy instead of browsermob-proxy #9
Open
dontcallmedom
wants to merge
13
commits into
w3c:master
Choose a base branch
from
dontcallmedom:node-thin2
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and raise timeout
set proper language tag require node 0.12
I get the same error as the travis build. |
@dontcallmedom, what is the status of this? Will this PR solve these issues with the Travis builds, namely having to use |
@dontcallmedom, your |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not backwards-compatible with the current version of the API; I have a separate update to w3c/Mobile-Checker to account for that that I'll submit once the npm version of this is available.