Skip to content

Commit

Permalink
Fix #333: Clarify transpose octave-change documentation (#366)
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael Good committed Jan 12, 2021
1 parent 8aebb97 commit 635fe05
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 8 deletions.
25 changes: 19 additions & 6 deletions schema/attributes.mod
Original file line number Diff line number Diff line change
Expand Up @@ -387,12 +387,25 @@
The transposition is represented by chromatic steps
(required) and three optional elements: diatonic pitch
steps, octave changes, and doubling an octave down. The
chromatic and octave-change elements are numeric values
added to the encoded pitch data to create the sounding
pitch. The diatonic element is also numeric and allows
for correct spelling of enharmonic transpositions.
steps, octave changes, and doubling an octave down.
The chromatic element represents the number of semitones
needed to get from written to sounding pitch. The diatonic
element specifies the number of pitch steps needed to go
from written to sounding pitch. This allows for correct
spelling of enharmonic transpositions. The octave-change
element indicates how many octaves to add to get from
written pitch to sounding pitch. Neither the chromatic nor
the diatonic element include octave-change values; the
values for both elements need to be added to the written
pitch to get the correct sounding pitch. The octave-change
element should be included when using transposition
intervals of an octave or more, and should not be present
for intervals of less than an octave. If the double element
is present, it indicates that the music is doubled one
octave down from what is currently written (as is the case
for mixed cello / bass parts in orchestral literature).
The optional number attribute refers to staff numbers,
from top to bottom on the system. If absent, the
transposition applies to all staves in the part. Per-staff
Expand Down
4 changes: 2 additions & 2 deletions schema/musicxml.xsd
Original file line number Diff line number Diff line change
Expand Up @@ -6015,7 +6015,7 @@ A score-instrument type is also required if the score specifies MIDI 1.0 channel
<xs:sequence>
<xs:element name="diatonic" type="xs:integer" minOccurs="0">
<xs:annotation>
<xs:documentation>The diatonic element specifies the number of pitch steps needed to go from written to sounding pitch. This allows for correct spelling of enharmonic transpositions.</xs:documentation>
<xs:documentation>The diatonic element specifies the number of pitch steps needed to go from written to sounding pitch. This allows for correct spelling of enharmonic transpositions. This value does not include octave-change values; the values for both elements need to be added to the written pitch to get the correct sounding pitch.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="chromatic" type="semitones">
Expand All @@ -6025,7 +6025,7 @@ A score-instrument type is also required if the score specifies MIDI 1.0 channel
</xs:element>
<xs:element name="octave-change" type="xs:integer" minOccurs="0">
<xs:annotation>
<xs:documentation>The octave-change element indicates how many octaves to add to get from written pitch to sounding pitch.</xs:documentation>
<xs:documentation>The octave-change element indicates how many octaves to add to get from written pitch to sounding pitch. The octave-change element should be included when using transposition intervals of an octave or more, and should not be present for intervals of less than an octave.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="double" type="empty" minOccurs="0">
Expand Down

0 comments on commit 635fe05

Please sign in to comment.