Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear what it means for multimeasure-rest to have an empty body #249

Closed
mscuthbert opened this issue Dec 6, 2017 · 2 comments
Closed
Milestone

Comments

@mscuthbert
Copy link
Contributor

Referring from #15 -- Not clear what it would mean for a multimeasure-rest to have an empty body -- obviously the number of measures wouldn't be displayed but how many measures of rest would to correspond to? It might be better to make the body type "positive-integer" instead of "positive-integer-or-empty" and add a separate attribute for "show-number" for %yes-no with default yes.

@mdgood
Copy link

mdgood commented Aug 4, 2020

It would seem the only use for having an empty element value would be to let the application determine the length of the multi-measure rest. But that does not seem very practical as many things go into choosing how to break up these types of rests. I wonder if this was simply a mistake, perhaps from copying and pasting a schema type definition without making a change.

If anybody is using empty <multiple-rest> elements, please let us know. At this time my plan is to follow @mscuthbert's suggestion to replace "positive-integer-or-empty" with "positive-integer". This means that some valid MusicXML 3.1 files won't be valid MusicXML 4.0 files if you use the XSD for validation. We try to avoid this, but have done it in the past to fix obvious mistakes in the schema that nobody has been using.

@mdgood
Copy link

mdgood commented Aug 6, 2020

Pull request #326 addresses this by changing the positive-integer-or-empty type to xs:positiveInteger. Looking at the schema I suspect this was a mistake made when copying the definition over from the <measure-repeat> element.

@mdgood mdgood closed this as completed Aug 7, 2020
@mdgood mdgood removed the In Progress label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants