New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add criticalCHRestart #188
Conversation
Website can indicate that a particular Client Hint is critical to the page by including it in a `Critical-CH` HTTP response header. Doing so will trigger a connection restart if the hint listed in the `Critical-CH` HTTP response header could be (but wasn't) included in the HTTP request initially sent. We should indicate this has happened in Navigation Timing so that developers can know if a restart occurred and impacted timing. We can pull this from the [navigable](https://wicg.github.io/client-hints-infrastructure/#has-reloaded-for-critical-ch) but I'm not quite sure if this is the right way to thread it. Closes #177
Is this specific to navigations? Subresources don't support this behavior? |
Yes that's correct. Just top-level navigations too (not iframes). |
Great! |
Done @noamr |
OK I'm missing two things here. without them this feels a bit hypothetical:
|
If this looks good otherwise, I believe that:
|
Not sure what you're responding to. Perhaps a different issue? |
Sorry, yes. Just updated the comment |
Yea, would like to see the whole picture. It's difficult to review addition of a new attribute without this context. |
Awesome, will check back in a couple weeks or so when that's done. |
This is needed for w3c/navigation-timing#188.
The WPTs just went in: https://chromium-review.googlesource.com/c/chromium/src/+/4538244 |
@noamr any feedback on WICG/client-hints-infrastructure#153? |
* Update Critical-CH restart time in navigation params This is needed for w3c/navigation-timing#188. * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs * Update index.bs
The other PR is in, can this be committed @noamr? |
Website can indicate that a particular Client Hint is critical to the page by including it in a
Critical-CH
HTTP response header. Doing so will trigger a connection restart if the hint listed in theCritical-CH
HTTP response header could be (but wasn't) included in the HTTP request initially sent. We should indicate this has happened in Navigation Timing so that developers can know if a restart occurred and impacted timing.We can pull this from the navigable but I'm not quite sure if this is the right way to thread it.
Closes #177
Preview | Diff