Remove redundant URL #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Reporting API now lets us provide a custom URL to associate the report with. The default is to use the containing document's URL, which isn't relevant for a NEL report. This lets us remove the `uri` field from the NEL body, removing a source of confusion about why they're different.
|
This depends on w3c/reporting#110 |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 19, 2018
Per w3c/network-error-logging#90, a NEL report's `url` field now contains the (sanitized) URL of the request that the report describes. (Before that spec update, it was supposed to contain the URL of the page that made the request, which isn't relevant for NEL.) Now that the report contains the "right" URL, the NEL body's `uri` field is redundant, and can be removed. Bug: 748549 Change-Id: Ibd2b0213b829e94329ecc7263baecd549d41e40c Reviewed-on: https://chromium-review.googlesource.com/1141271 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Douglas Creager <dcreager@chromium.org> Cr-Commit-Position: refs/heads/master@{#576312}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reporting API now lets us provide a custom URL to associate the report with. The default is to use the containing document's URL, which isn't relevant for a NEL report. This lets us remove the
urifield from the NEL body, removing a source of confusion about why they're different.