Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes algorithm and signing fields in agent certificate. #288

Merged
merged 24 commits into from
Nov 14, 2022
Merged

Fixes algorithm and signing fields in agent certificate. #288

merged 24 commits into from
Nov 14, 2022

Conversation

mfoltzgoogle
Copy link
Contributor

@mfoltzgoogle mfoltzgoogle commented Oct 27, 2021 •
edited by pr-preview bot
Loading

Addresses:

For the first item, it explicitly references the keyUsage bit for digitalSigning.

For the second item, I added a table that matches the TLS signature_scheme values to the AlgorithmIdentifier values that should be used in the certificate.

Preview | Diff

Preview | Diff

@mfoltzgoogle
Copy link
Contributor Author

@tidoust @chrisn Please take a look to ensure this makes sense and formatting is OK, then I will bring in Ryan to take a look as well.

@mfoltzgoogle
Copy link
Contributor Author

I believe this PR is still ready for review. We can review it next week as it's been open a while.

chrisn
chrisn reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@chrisn chrisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good. Just one suggestion on P-521.

index.bs Outdated Show resolved Hide resolved
tidoust
tidoust reviewed Sep 9, 2022
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
mfoltzgoogle and others added 3 commits September 9, 2022 11:34
@mfoltzgoogle @tidoust
Update index.bs
71dc491 
Co-authored-by: François Daoust <fd@tidoust.net>
@mfoltzgoogle
Add OIDs
1d5c721
@mfoltzgoogle
Fix indent
1bf4119
tidoust
tidoust reviewed Sep 12, 2022
View reviewed changes
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@mfoltzgoogle mfoltzgoogle mentioned this pull request Sep 13, 2022
Open
mfoltzgoogle and others added 13 commits November 7, 2022 14:55
@mfoltzgoogle
Copy link
Contributor Author

I have gone ahead and filled in the fields for secp384r1 and ecdsa-with-SHA384. Please take a look to see if you have any additional comments.

@mfoltzgoogle
Copy link
Contributor Author

Tagging @tidoust in case he didn't see my last comment :)

@mfoltzgoogle mfoltzgoogle merged commit 3f1f148 into main Nov 14, 2022
@mfoltzgoogle mfoltzgoogle deleted the issue-279-keyusage branch November 14, 2022 01:26
This was referenced Nov 14, 2022
Closed
Closed
github-actions bot added a commit that referenced this pull request Nov 14, 2022
@mfoltzgoogle @github-actions
Merge pull request #288 from w3c/issue-279-keyusage
bbe8ad3 
SHA: 3f1f148
Reason: push, by mfoltzgoogle

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisn chrisn chrisn approved these changes

@tidoust tidoust tidoust approved these changes

Assignees
No one assigned
Labels
F2F
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfoltzgoogle @chrisn @tidoust