Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in "events fire on RTCDataChannel" #358

Closed
ibc opened this issue Jan 17, 2016 · 2 comments
Closed

Error in "events fire on RTCDataChannel" #358

ibc opened this issue Jan 17, 2016 · 2 comments

Comments

@ibc
Copy link
Contributor

@ibc ibc commented Jan 17, 2016

In section 16 "Event summary":

captura de pantalla 2016-01-17 a las 18 00 57

I assume MessageEvent should be message, right?

@aboba
Copy link
Contributor

@aboba aboba commented Jan 19, 2016

Yes.

This table entry should be the same as in WebRTC 1.0 Section 12 under the Event Name "message", including the links to "MessageEvent".

@aboba
Copy link
Contributor

@aboba aboba commented Jan 19, 2016

Just noticed that the bufferedamountlow table entry (and associated attributes in RTCDataChannel) is missing in ORTC API. Specifically:

partial interface RTCDataChannel : EventTarget {
readonly attribute unsigned long bufferedAmount;
readonly attribute unsigned long bufferedAmountLowThreshold;
attribute EventHandler onbufferedamountlow;
};

aboba added a commit that referenced this issue Jan 19, 2016
Updated RTCDataChannel event table entries to match WebRTC 1.0 API Section 12. 

Fix for Issue #358
@aboba aboba closed this Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants