sender/receiver.setTransport(): Cannot replace closed transport(s)? #591

Closed
aboba opened this Issue Sep 9, 2016 · 0 comments

Projects

None yet

2 participants

@aboba
Contributor
aboba commented Sep 9, 2016

Section 5.3 (sender.setTransport) and Section 6.3 (receiver.setTransport) both contain the following sentence:

"If stop() has been called, or transport.state or rtcpTransport.state is closed, throw an InvalidStateError exception."

Why is it not possible for setTransport to replace an RTP or RTCP transport in the "closed" state?

@aboba aboba changed the title from sender/receiver.setTransport(): Cannot replace stop'd transport? to sender/receiver.setTransport(): Cannot replace closed transport(s)? Sep 9, 2016
@aboba aboba added a commit that referenced this issue Sep 9, 2016
@aboba aboba sender/receiver.setTransport(): replacing closed transport(s)
Fix for Issue #591
4185b59
@aboba aboba added the PR exists label Sep 9, 2016
@aboba aboba added a commit that referenced this issue Sep 12, 2016
@aboba aboba Revision to setTransport()
This PR:

1. Removes checks on transport.state and rtcpTransport.state (so that closed or failed transports can be replaced)
2. Removes checks on withTransport.state and withRtcpTransport.state (removing a potential race condition with the statechange EventHandler).
3. Leaves setTransport as a synchronous method.


Revised fix for Issue #591
3e6b9df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment