Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sender/receiver.setTransport(): Cannot replace closed transport(s)? #591

Closed
aboba opened this issue Sep 9, 2016 · 0 comments
Closed

sender/receiver.setTransport(): Cannot replace closed transport(s)? #591

aboba opened this issue Sep 9, 2016 · 0 comments
Labels
PR exists

Comments

@aboba
Copy link
Contributor

aboba commented Sep 9, 2016

Section 5.3 (sender.setTransport) and Section 6.3 (receiver.setTransport) both contain the following sentence:

"If stop() has been called, or transport.state or rtcpTransport.state is closed, throw an InvalidStateError exception."

Why is it not possible for setTransport to replace an RTP or RTCP transport in the "closed" state?
@aboba aboba changed the title sender/receiver.setTransport(): Cannot replace stop'd transport? sender/receiver.setTransport(): Cannot replace closed transport(s)? Sep 9, 2016
aboba added a commit that referenced this issue Sep 9, 2016
@aboba
sender/receiver.setTransport(): replacing closed transport(s)
4185b59 
Fix for Issue #591
@aboba aboba mentioned this issue Sep 9, 2016
Merged
@aboba aboba added the PR exists label Sep 9, 2016
aboba added a commit that referenced this issue Sep 12, 2016
@aboba
Revision to setTransport()
3e6b9df 
This PR:

1. Removes checks on transport.state and rtcpTransport.state (so that closed or failed transports can be replaced)
2. Removes checks on withTransport.state and withRtcpTransport.state (removing a potential race condition with the statechange EventHandler).
3. Leaves setTransport as a synchronous method.


Revised fix for Issue #591
@aboba aboba mentioned this issue Sep 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aboba @robin-raymond