New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RTCRtpSender construction with a null transport #682
Conversation
Fix for Issue #679
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. May also want to change the last step in send()
's algorithm to "If send() is called for the first time, and transport
is set, start sending."
<code>transport</code> (and if used) RTCP <code><a>RTCDtlsTransport</a></code> | ||
<code>rtcpTransport</code> with the transport(s) provided.</p> | ||
<code>transport</code> (if set) and RTCP <code><a>RTCDtlsTransport</a></code> | ||
<code>rtcpTransport</code> (if used) with the transport(s) provided.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should an exception be thrown if rtcpTransport
is set but transport
isn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
index.html
Outdated
@@ -3225,6 +3225,10 @@ | |||
reject <var>p</var> with <code>InvalidStateError</code>.</p> | |||
</li> | |||
<li> | |||
<p>If <code><var>sender</var>.transport()</code> is unset, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need parentheses here
to augment what @taylor-b said: if send() is called, transport is not set then setTransport needs to start sending (which requires an internal send state?) And we need the same for RTPReceiver too |
Fix for Issue #679