This repository has been archived by the owner on Jul 18, 2022. It is now read-only.
Rewrite to operate on browsing contexts #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavweiss
reviewed
Jun 5, 2020
index.html
Outdated
| </dd> | ||
| <dt> | ||
| <dfn data-dfn-for="Document" data-export="" data-dfn-type= | ||
| "dfn">visible</dfn> | ||
| </dt> | ||
| <dd> | ||
| The {{Document}} is at least partially visible on at least one | ||
| screen. | ||
| screen, as determined by running the steps to [=determine the | ||
| visibility state=] of a [=browsing context=]. |
There was a problem hiding this comment.
I think you want to define which browsing context you're passing as input. Maybe "Document's relevant global object's browsing context" ?
There was a problem hiding this comment.
Ah, I wanted to leave this up to each calling algorithm - but can add here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to make this spec more usable by other specs... other specs can now "determine the visibility" of a given browsing context. The algorithm finds to the top-level browsing context, and determines the visibility from there.
This is largely just refactor, it doesn't change any normative requirements.
I also added myself as co-editor, as I figure I might as well keep helping to maintain this spec.
Preview | Diff