Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify paints outside viewport #59

Merged
merged 1 commit into from Mar 5, 2020
Merged

Clarify paints outside viewport #59

merged 1 commit into from Mar 5, 2020

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Mar 5, 2020

FP and FCP must consider contents that are painted outside of the viewport. This is only relevant in odd edge cases and is done for simplicity and performance. Fixes #58


Preview | Diff

FP and FCP must consider contents that are painted outside of the viewport. This is only relevant in odd edge cases and is done for simplicity and performance. Fixes #58
@npm1 npm1 requested a review from yoavweiss March 5, 2020 16:41
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npm1 npm1 merged commit 71c2f31 into master Mar 5, 2020
@npm1 npm1 deleted the outside-viewport branch March 5, 2020 16:57
@smfr
Copy link

smfr commented Mar 5, 2020

I wouldn't qualify them as "odd edge cases". Painting outside the viewport is very common.

@npm1
Copy link
Contributor Author

npm1 commented Mar 5, 2020

It is an 'odd edge case' to ONLY paint outside the viewport.

<dfn export>First Contentful Paint</dfn> entry contains a {{DOMHighResTimeStamp}} reporting the time when the browser first rendered any text, image (including background images), non-white canvas or SVG. This excludes any content of iframes, but includes text with pending webfonts. This is the first time users could start consuming page content.
<dfn export>First Contentful Paint</dfn> entry contains a {{DOMHighResTimeStamp}} reporting the time when the user agent first rendered any text, image (including background images), non-white canvas or SVG. This excludes any content of iframes, but includes text with pending webfonts. This is the first time users could start consuming page content.

Whenever a user agent preemptively paints content outside of the viewport, those paints MUST be considered for <a>First Paint</a> and <a>First Contentful Paint</a>.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify whether First Contentful Paint considers content outside the viewport
4 participants