Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note re blank pages #72

Merged
merged 1 commit into from Mar 23, 2020
Merged

Add note re blank pages #72

merged 1 commit into from Mar 23, 2020

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 22, 2020 •
edited by pr-preview bot

@noamr noamr requested review from rniwa and npm1 March 22, 2020 07:26
@noamr noamr mentioned this pull request Mar 22, 2020
Closed
@rniwa
Copy link

rniwa commented Mar 23, 2020

Looks okay to me.

@noamr noamr merged commit 4e2bad2 into master Mar 23, 2020
npm1
npm1 reviewed Mar 23, 2020
View reviewed changes
painttiming.bs
@@ -186,7 +186,9 @@ Reporting paint timing {#sec-reporting-paint-timing}

1. If this instance of [=update the rendering=] is the [=first contentful paint=] of |document|, then invoke the [[#report-paint-timing]] algorithm with |document|, <code>"first-contentful-paint"</code>, and |paintTimestamp| as arguments.

NOTE: A parent frame should not be aware of the paint events from its child iframes, and vice versa. This means that a frame that contains just iframes will have [=first paint=] (due to the enclosing boxes of the iframes) but no [=first contentful paint=].
NOTE: A parent frame should not be aware of the paint events from its child iframes, and vice versa. This means that a frame that contains just iframes, will have [=first paint=] (due to the enclosing boxes of the iframes) but no [=first contentful paint=].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you accidentally added a comma here after contains just iframes (there shouldn't be one).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! fixing

@yoavweiss yoavweiss deleted the note-empty branch February 3, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npm1 npm1 npm1 left review comments

@rniwa rniwa rniwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noamr @rniwa @npm1