Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: trim introduction #227

Merged
merged 1 commit into from Dec 3, 2017
Merged

Editorial: trim introduction #227

merged 1 commit into from Dec 3, 2017

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Nov 27, 2017 •
edited by pr-preview bot

adrianhopebailie
adrianhopebailie approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@adrianhopebailie adrianhopebailie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally +1 to these changes.

You explicitly dropped the terminology "Payment App" from the document which I am supportive of but has been the subject of much debate. Probably needs wide review.

@marcoscaceres
Copy link
Member Author

Will wait for @ianbjacobs to review also.

@marcoscaceres marcoscaceres merged commit 388c3c3 into gh-pages Dec 3, 2017
@marcoscaceres marcoscaceres deleted the introduction branch December 3, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianhopebailie adrianhopebailie adrianhopebailie approved these changes

@ianbjacobs ianbjacobs ianbjacobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcoscaceres @adrianhopebailie @ianbjacobs