Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify merchant that payment method (possibly including the billing address) changed in payment handler. #318

Merged
merged 6 commits into from
Sep 14, 2018
Merged

Notify merchant that payment method (possibly including the billing address) changed in payment handler. #318

merged 6 commits into from
Sep 14, 2018

Commits on Sep 12, 2018

  1. PaymentRequestEvent.changePaymentMethod(methodName, methodDetails). 

    This patch adds a method for the payment handler to notify the payee
that the payment method has changed. This enables the payee to update
the total based on the billing address or validate the billing address,
for example.
    @rsolomakhin
    rsolomakhin committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    d24b5cf View commit details
    Browse the repository at this point in the history

  2. Generic payment method errors instead of billing address specific.

    @rsolomakhin
    rsolomakhin committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    4570354 View commit details
    Browse the repository at this point in the history

  3. Address comments.

    @rsolomakhin
    rsolomakhin committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    5116da1 View commit details
    Browse the repository at this point in the history

  4. Use PaymentCurrencyAmount type total

    @rsolomakhin
    rsolomakhin committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    2c69862 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Do not use a dictionary as an attribute.

    @rsolomakhin
    rsolomakhin committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    f25d42f View commit details
    Browse the repository at this point in the history

  2. Make methodDetails optional.

    @rsolomakhin
    rsolomakhin committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    3525c7a View commit details
    Browse the repository at this point in the history