add requestSecurityCode member to BasicCardRequest

[ianbjacobs]

Relates to
w3c/payment-request#97

It does not close that issue because this solution is payment method specific (and also does not address all the fields within Basic Card; however it does address the one that has been cited).

The following tasks have been completed:

• Confirmed there are no ReSpec errors/warnings.
• Added Web platform tests (link)
• added MDN Docs (link)

Implementation commitments:

• Chrome (link to issue)
• Firefox
• Edge (public signal)

---

Preview | Diff

[marcoscaceres]

I'm ok with this

[marcoscaceres]

Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1546859

[marcoscaceres]

Sent a patch to Gecko. Note that it only patches the DOM implementation. We don't have a basic card UI.

[rsolomakhin]

This looks right 👍

[marcoscaceres]

We should probably add a manual test before merging.

[rsolomakhin]

Good idea.

…

--Rouslan

On Mon, Apr 29, 2019 at 5:08 PM Marcos Cáceres ***@***.***> wrote: We should probably add a manual test before merging. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#78 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAH3EGOCXRXOGJKFXDR6RATPS5PWVANCNFSM4HIHYUZA> .

[marcoscaceres]

@rsolomakhin or @danyao, just wondering if this ever landed in Chrome?

[rsolomakhin]

This did not land in Chrome yet, @marcoscaceres .

[marcoscaceres]

@rsolomakhin thanks for confirming. I guess we should wait till it's in Chrome before we land this, otherwise it might confuse people.

[Krystosterone]

I like this and believe this makes sense

[marcoscaceres]

@rsolomakhin or @danyao, any update on the Chrome side about supporting this?

[rsolomakhin]

Hi @marcoscaceres , at this point we're investing heavily into payment handlers (both web based and OS-specific apps), so let's bypass waiting for Chrome to update it's basic-card implementation. Instead, let's update the spec and encourage payment apps that implement the basic-card standard to implement support for this new field as well. WDYT?

[marcoscaceres]

Ah, just stumbled onto https://blog.chromium.org/2020/01/rethinking-payment-request-for-ios.html

Sounds like we might want to wrap up Basic Card entirely then.

[rsolomakhin]

Sounds like we might want to wrap up Basic Card entirely then.

The Basic Card standard can exist for 3rd party payment handlers to implement and for merchants to use, if they wish. It's just not Google's cup of tea to implement it, though. We'd much rather focus on Payment Request and Payment Handler standards.

Edit: More precise wording.

[ianbjacobs]

I think that we should maintain Basic Card as a Note.

[marcoscaceres]

Ok, the above sounds like a plan.