Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding examples of payment matching algorithm #498

Closed
mattsaxon opened this issue Apr 3, 2017 · 3 comments
Closed

Consider adding examples of payment matching algorithm #498

mattsaxon opened this issue Apr 3, 2017 · 3 comments
Assignees

Comments

@mattsaxon
Copy link
Contributor

In show() step 8.1, an example would be useful, especially considering the language used isn't easy to pass e.g. "the second element of the tuple"

@marcoscaceres
Copy link
Member

Might destructure the tuple into vars, for easier reading. I agree that "the second element of the tuple" is a bit confusing.

@marcoscaceres
Copy link
Member

@mattsaxon, I've prepared a PR for this, but I'm reluctant to add an example there because we want implementers to implement from algorithms not examples.

See #530 and let me know if it's ok.

@mattsaxon
Copy link
Contributor Author

@marcoscacares, thanks, happy with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants