New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descriptions of change events attributes are somewhat misleading #538

Closed

2 tasks done

marcoscaceres opened this issue May 29, 2017 · 0 comments

Closed

2 tasks done

Descriptions of change events attributes are somewhat misleading #538

marcoscaceres opened this issue May 29, 2017 · 0 comments

Labels

Member

marcoscaceres commented May 29, 2017 •

edited

It says, for example:

A PaymentRequest's onshippingaddresschange attribute is an EventHandler for an Event named PaymentRequestUpdateEvent.

It actually fires a "PaymentRequestUpdateEvent" (which inherits Event).

Attributes that need rewording:

onshippingaddresschange
onshippingoptionchange

marcoscaceres added the Editorial label

marcoscaceres added a commit that referenced this issue


          editorial: s/Event/PaymentRequestUpdateEvent (closes #538)

fbcdd68

marcoscaceres added a commit that referenced this issue


          editorial: s/Event/PaymentRequestUpdateEvent (closes #538)

ca6100e

marcoscaceres closed this as completed in

00b1ffb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment