Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject acceptedPromise if payment method identifer is invalid #557

Closed
adrianhopebailie opened this issue Jun 29, 2017 · 1 comment
Closed
Milestone

Comments

@adrianhopebailie
Copy link
Collaborator

Per suggestion here for consistency with fail fast design: #536 (comment)

The payment identifiers provided in a request should be valid (per the PMI spec) and can either be checked as part of the show() algorithm at step 11 here or earlier at step 4.2 of the Payment Request constructor here although this is likely more processing than desired inside a constructor.

Assuming this check is implemented in the show() algorithm it should result in the promise being rejected. The error to use is up for debate...

URL parsing error seems best for a URL identifier unless the issue is specific to payment method identifiers (not using https etc)

@marcoscaceres marcoscaceres added this to the CR milestone Jul 24, 2017
@marcoscaceres
Copy link
Member

Closing as duplicate of #464.

@adrianhopebailie, I'm about to send a PR that ignores the invalid ones during construction as per #464.

Checking what UAs do in the tests (coming also with PR).

@marcoscaceres marcoscaceres marked this as a duplicate of #464 Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants