Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error? 55 + 5 = 65 #622

Closed
edent opened this issue Sep 18, 2017 · 1 comment
Closed

Documentation error? 55 + 5 = 65 #622

edent opened this issue Sep 18, 2017 · 1 comment

Comments

@edent
Copy link
Member

edent commented Sep 18, 2017

"2.2 The details argument" shows

        displayItems: [
          {
            label: "Sub-total",
            amount: { currency: "USD", value: "55.00" },
          },
          {
            label: "Sales Tax",
            amount: { currency: "USD", value: "5.00" },
          },
        ],
        total: {
          label: "Total due",
          amount: { currency: "USD", value: "65.00" },

https://github.com/w3c/payment-request/blob/gh-pages/index.html#L288

If my mathematic reasoning is correct, 55+5=60. Or have I misunderstood what the code is trying to say?

@edent edent mentioned this issue Sep 18, 2017
marcoscaceres pushed a commit that referenced this issue Sep 18, 2017
The numbers didn't add up.

Fixes #622
@marcoscaceres marcoscaceres reopened this Sep 18, 2017
@marcoscaceres
Copy link
Member

Just realized the $5 comes from the selected shipping option. But it was wrong not to have a comment not explaining that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants