New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NewObject] annotation #743

Closed

1 task

marcoscaceres opened this issue Jun 28, 2018 · 1 comment · Fixed by #746

Assignees

Labels

Editorial Has Pull Request

Member

marcoscaceres commented Jun 28, 2018 •

edited

Methods, like .complete(), show(), etc. always return a new object. They should probably be marked as [NewObject].

Web platform tests

marcoscaceres added the Editorial label

marcoscaceres mentioned this issue

Add [NewObject] annotations to methods #746

Merged

1 task

marcoscaceres self-assigned this

marcoscaceres added the Has Pull Request label

Member Author

marcoscaceres commented Jul 3, 2018

Adding tests web-platform-tests/wpt#11775

domenic closed this as completed in #746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment